On Tue, 25 Nov 2025 14:44:24 GMT, Ambarish Rapte <[email protected]> wrote:

> The `build.gradle` file contains separate tasks for compiling each standalone 
> metal shader file.
> The 5 tasks are combined into a single task.
> 
> Verification:
> 1. Verify that build completes successfully, and the 5 **.metal** files are 
> correctly compiled and 5 **.air** files are generated in directory : 
> _modules/javafx.graphics/build/msl_
> `ClearRttShaders.air`,  `ComputeKernels.air`,  `PassThroughVS.air`,  
> `PhongPS.air`,  `PhongVS.air`
> 3. Basic sanity testing

Code change looks good to me.
I can confirm that 5 .metal and .air gets generated properly and basic sanity 
testing using Ensemble8 also looks good.

-------------

Marked as reviewed by jdv (Committer).

PR Review: https://git.openjdk.org/jfx/pull/1984#pullrequestreview-3513583070

Reply via email to