On Mon, 12 Jan 2026 14:11:48 GMT, Christopher Schnick <[email protected]> wrote:
> This PR replaces various catch blocks for NPEs by proper null checks. It
> looks like a lot but most of the binding changes are just variants of the
> same approach. The test cases have been adapted to not check for NPEs anymore.
>
> The PrismFontFactory change to a RuntimeException was made because I don't
> see how the try block can throw an NPE.
modules/javafx.base/src/main/java/com/sun/javafx/binding/SelectBinding.java
line 199:
> 197: return numberVal.doubleValue();
> 198: } else if (val != null) {
> 199: Logging.getLogger().warning("Value of select-binding has
> wrong type, returning default value.");
minor: I would re-phrase it as something like "Expecting a Number value" (here
and elsewhere)
modules/javafx.graphics/src/main/java/javafx/scene/Scene.java line 5187:
> 5185: } else {
> 5186: Integer result = slowMap.get(id);
> 5187: if (result == null) {
I don't think this is an equivalent change
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2032#discussion_r2683187492
PR Review Comment: https://git.openjdk.org/jfx/pull/2032#discussion_r2683199783
