On Tue, 13 Jan 2026 20:10:25 GMT, Christopher Schnick <[email protected]> wrote:

>> This PR replaces various catch blocks for NPEs by proper null checks. It 
>> looks like a lot but most of the binding changes are just variants of the 
>> same approach. The test cases have been adapted to not check for NPEs 
>> anymore.
>> 
>> The PrismFontFactory change to a RuntimeException was made because I don't 
>> see how the try block can throw an NPE.
>
> Christopher Schnick has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Remove unnecessary catch block

Looks good, thank you!

FYI there is another one https://bugs.openjdk.org/browse/JDK-8201135 which 
throws a bunch unnecessary exceptions during CSS color parsing, though the fix 
may not be as trivial.

-------------

Marked as reviewed by angorya (Reviewer).

PR Review: https://git.openjdk.org/jfx/pull/2032#pullrequestreview-3662336643

Reply via email to