> The resize method in the combo box skin does not take into account whether 
> the popup was autofixed or not. This causes a wrong position if the content 
> size is changed, which it often is on initial show.
> 
> If anyone has a better idea how to actually determine whether a popup was 
> autofixed, then I can improve the check. Currently it relies purely on the 
> popup position and the combo box position.
> 
> I tested this fix manually on Windows with a reproducer and it works as 
> expected there

Christopher Schnick has updated the pull request incrementally with two 
additional commits since the last revision:

 - Update comments
 - Improve positioning

-------------

Changes:
  - all: https://git.openjdk.org/jfx/pull/2044/files
  - new: https://git.openjdk.org/jfx/pull/2044/files/86520bd9..c9f33f35

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jfx&pr=2044&range=02
 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=2044&range=01-02

  Stats: 7 lines in 1 file changed: 1 ins; 1 del; 5 mod
  Patch: https://git.openjdk.org/jfx/pull/2044.diff
  Fetch: git fetch https://git.openjdk.org/jfx.git pull/2044/head:pull/2044

PR: https://git.openjdk.org/jfx/pull/2044

Reply via email to