On Wed, 21 Jan 2026 12:15:38 GMT, Christopher Schnick <[email protected]> wrote:
>> The resize method in the combo box skin does not take into account whether >> the popup was autofixed or not. This causes a wrong position if the content >> size is changed, which it often is on initial show. >> >> If anyone has a better idea how to actually determine whether a popup was >> autofixed, then I can improve the check. Currently it relies purely on the >> popup position and the combo box position. >> >> I tested this fix manually on Windows with a reproducer and it works as >> expected there > > Christopher Schnick has updated the pull request incrementally with two > additional commits since the last revision: > > - Update comments > - Improve positioning Thank you, somehow the latest changes make more sense by removing the dependency on the height change. (Just to be sure, the test https://github.com/andy-goryachev-oracle/Test/blob/main/src/goryachev/bugs/ComboBox_WrongLocation_8338145.java changes the number of items each time the popup is shown) Looks good on macOS 26.2 and windows 11. Please test it on Linux, though it should not have any platform-specific differences in my opinion. ------------- Marked as reviewed by angorya (Reviewer). PR Review: https://git.openjdk.org/jfx/pull/2044#pullrequestreview-3689787781
