On Wed, 11 Mar 2026 14:07:22 GMT, Ambarish Rapte <[email protected]> wrote:
>> Jose Pereda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address feedback from reviewer
>
> tests/system/src/test/java/test/robot/javafx/scene/SystemMenuBarEnableTest.java
> line 143:
>
>> 141: });
>> 142: Util.sleep(2 * DELAY);
>> 143: }
>
> optional: I would recommend to add another **Util.runAndWait** block here to
> close the menu. and remove the calls `robotMenu(false, false, false);`
>
>
> // hide menu
> Util.runAndWait(() -> {
> Robot robot = new Robot();
> robot.keyType(KeyCode.ESCAPE);
> });
>
>
> I had this comment earlier batch, it wasn't posted. not sure why.
Good idea, done!
> tests/system/src/test/java/test/robot/javafx/scene/SystemMenuBarEnableTest.java
> line 148:
>
>> 146: public static class TestApp extends Application {
>> 147:
>> 148: private Menu menu;
>
> With the other variable, even the variable `menu` could move to outer class.
> and we can remove the variable `testApp`
done!
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2103#discussion_r2920747421
PR Review Comment: https://git.openjdk.org/jfx/pull/2103#discussion_r2920745790
