On Thu, 12 Mar 2026 18:25:36 GMT, Andy Goryachev <[email protected]> wrote:
>> Jose Pereda has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Address feedback
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/tk/quantum/GlassSystemMenu.java
> line 249:
>
>> 247: }
>> 248: } else {
>> 249: final MenuItem glassSubMenuItem =
>> app.createMenuItem(parseText(menuitem), null);
>
> minor: `final` is not necessary for _effectively final_ declarations
Removed
> tests/system/src/test/java/test/robot/javafx/scene/SystemMenuBarEnableTest.java
> line 90:
>
>> 88: @Test
>> 89: void testMenuItemEnabledAfterParentReEnabled() {
>> 90: Assumptions.assumeTrue(PlatformUtil.isMac(), "System menu bar
>> tests only apply to macOS");
>
> Unrelated question: this is the only `@Test` here - will the frame be
> displayed on Windows? Or junit will not even run the test?
>
> Can the whole test be skipped on non-macOS systems?
Running this test on other system will just show `SKIPPED`.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2103#discussion_r2927830913
PR Review Comment: https://git.openjdk.org/jfx/pull/2103#discussion_r2927841904
