On Thu, 15 Jan 2026 16:47:28 GMT, John Hendrikx <[email protected]> wrote:

>> This new check is much more accurate to detect whether a parent is currently 
>> laying out its children. The previous code almost never worked, resulting in 
>> additional unnecessary layouts.
>
> John Hendrikx has updated the pull request with a new target base due to a 
> merge or a rebase. The pull request now contains five commits:
> 
>  - Merge branch 'master' into feature/in-layoutchildren-detection-for-node
>  - Rename test
>  - Add regression test
>  - Fix ToolBarSkinTest
>    
>    Reusing a toolbar as part of several scenes, in combination with the 
> StubToolkit that doesn't handle pulses makes this test fail with the relayout 
> detection fix.
>  - Change how Node detects whether a relayout is required
>    
>    This new check is much more accurate to detect whether a parent is 
> currently laying out its children. The previous code almost never worked, 
> resulting in additional unnecessary layouts.

> Do we still have this issue: [#1945 
> (comment)](https://github.com/openjdk/jfx/pull/1945#issuecomment-3657134694)
> 
> Or did I miss a new commit since then?

You said that was on the current master branch, or is this an issue with this 
PR specifically?

-------------

PR Comment: https://git.openjdk.org/jfx/pull/1945#issuecomment-4057482651

Reply via email to