On Fri, 13 Mar 2026 19:38:51 GMT, Andy Goryachev <[email protected]> wrote:
> ok, I'll take another look. Thanks. > btw, at least one minor comment was not reacted to: > https://github.com/openjdk/jfx/pull/1945/changes#r2466840973 Yes, will do so if this is deemed acceptable at all. > also, whatever happened to the idea to re-layout 2 or 3 times immediately in > sequence? If this doesn't introduce any problems, we could either incorporate this or do this in a separate PR. Although non-converging layouts are not preferred, it may not be always possible to avoid these, and doing perhaps 2 or 3 layouts before rendering a frame would at least make those situations a bit more bearable as less bad frames are rendered where the UI is still converging. It would require a bit more work then this simple adjustment, as you'd probably want to have a parameter to play with (how many layouts max) and perhaps another parameter to turn on warnings for extra layout passes to aid debugging so we may eventually perhaps resolve these issues at least in FX controls (or discover there are really situations that are unresolvable with 1 pass). There is also I believe a related PR for this, so we should coordinate there. If we're really still unsure about this, we could put it behind a parameter easily enough so at least it can be investigated more easily on various configurations. I wouldn't have touched this if it weren't for the fact that the current check doesn't work at all; there was definitely an intention behind the check to only do an extra layout pass if needed, but it currently just always keeps doing layout passes until nothing changed at all. ------------- PR Comment: https://git.openjdk.org/jfx/pull/1945#issuecomment-4058586936
