On Mon, 16 Mar 2026 18:44:16 GMT, Andy Goryachev <[email protected]> wrote:
>> chuckyschluz has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> minor cleanup
>
> modules/javafx.controls/src/main/java/javafx/scene/control/MultipleSelectionModelBase.java
> line 741:
>
>> 739: public void set(int index, int end, boolean isSet) {
>> 740: _beginChange();
>> 741: size = -1;
>
> was this change necessary?
We only need to invalidate the cache after `bitset.set(index, end, isSet);`. In
the `!isSet` case, we need `indexOf` before we modify the bitset.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2100#discussion_r2942594825
