> Fixes [JDK-8311505](https://bugs.openjdk.org/browse/JDK-8311505) > > This PR uses `set(int index, int end, boolean isSet)` in > `javafx.scene.control.MultipleSelectionModelBase` to avoid excessive calls to > `indexOf` when deselecting continuous ranges of rows. > > Benchmarks produced with the test application provided here: > https://bugs.openjdk.org/browse/JDK-8311505 > > Before (mainline): > > > Select item count 500000 took 724 > Deselect item count 500000 took 73103 > > > After (this PR): > > > Select item count 500000 took 249 > Deselect item count 500000 took 88 > > > Passes all unit tests: > > `.\gradlew.bat :controls:test` > `.\gradlew.bat :systemTests:test` > > Thank you!
chuckyschluz has updated the pull request incrementally with one additional commit since the last revision: use bitset instead of boxed integers ------------- Changes: - all: https://git.openjdk.org/jfx/pull/2100/files - new: https://git.openjdk.org/jfx/pull/2100/files/97fe81f6..79003151 Webrevs: - full: https://webrevs.openjdk.org/?repo=jfx&pr=2100&range=02 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=2100&range=01-02 Stats: 25 lines in 1 file changed: 3 ins; 8 del; 14 mod Patch: https://git.openjdk.org/jfx/pull/2100.diff Fetch: git fetch https://git.openjdk.org/jfx.git pull/2100/head:pull/2100 PR: https://git.openjdk.org/jfx/pull/2100
