On Tue, 24 Mar 2026 10:15:56 GMT, Ajit Ghaisas <[email protected]> wrote:

>>> Another idea is maybe add a list change listener to the skin's 
>>> `popup.getItems()` and check whether adding an N items triggers one change 
>>> instead of N. What do you think?
>> 
>> That is indeed an easy but still effective idea for a test. I think we 
>> should try it!
>
> Please see - whether the system test added in 
> https://github.com/openjdk/jfx/pull/34 can be used as a reference while 
> writing a test for this fix?

Thanks for the reference!
While I think this would also work, I like the suggestion from Andy. 
The ticket is about the performance, but what we would like to ensure is that 
we do not spam the `ListChangeListener` of the underlying `Popup` with many 
single changes but do everything as a batch instead.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/2118#discussion_r2980613792

Reply via email to