On Tue, 24 Mar 2026 18:56:32 GMT, Andy Goryachev <[email protected]> wrote:
>> Philemon Hilscher has updated the pull request incrementally with one >> additional commit since the last revision: >> >> 8303060: Improve set items and add change listener to tests >> >> Signed-off-by: Philemon Hilscher <[email protected]> > > modules/javafx.controls/src/test/java/test/javafx/scene/control/ChoiceBoxTest.java > line 620: > >> 618: AtomicInteger changeCount = new AtomicInteger(); >> 619: choiceBoxPopup.getItems() >> 620: .addListener((ListChangeListener.Change<? extends >> MenuItem> _) -> changeCount.incrementAndGet()); > > this is very minor, but I'd recommend this format - it's clearer and one can > actually set a breakpoint inside the listener: > > choiceBoxPopup.getItems().addListener((ListChangeListener.Change<? extends > MenuItem> _) -> { > changeCount.incrementAndGet(); > }); I actually used the Intellij debug option during test development to set the breakpoint just there, so it should be no problem to debug it. <img width="1078" height="112" alt="Image" src="https://github.com/user-attachments/assets/9ea89e18-f9a1-45b8-b38c-64758bb1af40"; /> ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2118#discussion_r2983884277
