> When a non-opaque scene fill color is used with a stage style other than > `StageStyle.TRANSPARENT`, the actual fill color is always white. This doesn't > work well when the scene uses a dark color scheme. A practical solution is to > allow non-opaque scene fill colors, and blend them on top of a white or black > background (depending on color scheme) to derive an opaque color that adapts > intuitively to the color scheme. > > To test this, simply create a scene that uses a non-opaque fill color and > observe the scene background when the color scheme is changed. > > This PR includes a system test, run it with: > > ./gradlew -PFULL_TEST=true -PUSE_ROBOT=true :systemTests:test --tests > test.robot.javafx.scene.SceneFillTest.testSceneFill
Michael Strauß has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains 10 additional commits since the last revision: - comment - Merge branch 'master' into feature/scene-fill - use ChangeListener instead of InvalidationListener - import - check FX thread - Update window background when scene fill changes - Update window background when ColorScheme changes - review comments - Clear background to dominant fill color - Adjust scene background to color scheme ------------- Changes: - all: https://git.openjdk.org/jfx/pull/2068/files - new: https://git.openjdk.org/jfx/pull/2068/files/cc69cad5..a21735ea Webrevs: - full: https://webrevs.openjdk.org/?repo=jfx&pr=2068&range=07 - incr: https://webrevs.openjdk.org/?repo=jfx&pr=2068&range=06-07 Stats: 60888 lines in 418 files changed: 22626 ins; 16929 del; 21333 mod Patch: https://git.openjdk.org/jfx/pull/2068.diff Fetch: git fetch https://git.openjdk.org/jfx.git pull/2068/head:pull/2068 PR: https://git.openjdk.org/jfx/pull/2068
