On Tue, 24 Mar 2026 22:37:14 GMT, Martin Fox <[email protected]> wrote:

>> Michael Strauß has updated the pull request incrementally with one 
>> additional commit since the last revision:
>> 
>>   import
>
> modules/javafx.graphics/src/main/java/com/sun/javafx/util/Utils.java line 244:
> 
>> 242:             }
>> 243: 
>> 244:             case ImagePattern pattern -> 
>> ImageUtils.computeDominantColor(pattern.getImage(), background);
> 
> I know JavaFX has the notion of background image loading. Is that relevant 
> here? This code is changing the timing; it will access the image's pixels 
> before the stage is even shown instead of waiting for a render pass.

`ImagePattern` doesn't accept background-loading images, so the problem doesn't 
exist.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/2068#discussion_r2985086146

Reply via email to