On Wed, 20 May 2026 09:15:05 GMT, Michael Strauß <[email protected]> wrote:
>> fx uses multiple metaphors, there is no single prescribed manner, I think. >> For example, a null `HBox.alignment` is functionally equivalent to >> `Pos.TOP_LEFT` (HBox:336) >> >> The design principle that I would consider more important is `frequent use >> cases should be easy, everything else should be possible`. In your case, >> all you need with this PR is to install a factory that produces a `null` >> `Node`, and this is not what I would think is the most frequent case, which >> is just to show the same icons that the application set on tabs. >> >> Also, I really dislike the DEFAULT_MENU_GRAPHIC_FACTORY idea - exposing >> something internal for no purpose whatsoever. Maybe I should just close >> this PR. > >> Also, I really dislike the DEFAULT_MENU_GRAPHIC_FACTORY idea - exposing >> something internal for no purpose whatsoever. Maybe I should just close this >> PR. > > It isn't internal, it's user-facing behavior and therefore not internal by > definition. Your own proposal adds documentation for the default behavior, > which we wouldn't do if it was an implementation detail. It _was_ internal in the original proposal. In fact, we `could` improve the default behavior by adding, let's say, support for arbitrary `Path`s, but with the public factory it's set in stone. I think I should revert the public factory and go back to `null` signifying the default behavior, whatever that is. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1773#discussion_r3274661286
