On Wed, 20 May 2026 14:17:01 GMT, Andy Goryachev <[email protected]> wrote:
> It _was_ internal in the original proposal. In fact, we `could` improve the
> default behavior by adding, let's say, support for arbitrary `Path`s, but
> with the public factory it's set in stone.
>
> I think I should revert the public factory and go back to `null` signifying
> the default behavior, whatever that is.
This is the text of your original proposal:
/**
* ...
* When this property is {@code null}, the menu provides only the basic
graphic copied from the corresponding
* {@link Tab} - either an {@link ImageView} or a {@link Label} with an
{@link ImageView} as its graphic.
* ...
*/
public final ObjectProperty<Function<Tab, Node>>
menuGraphicFactoryProperty() {
An observable behavior that is described in documentation can _never_ be an
internal implementation detail; it is part of the public contract of the class.
Whether it has its own API element (like a constant field) isn't relevant.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/1773#discussion_r3274953467
