On Thu, 21 May 2026 22:52:34 GMT, Andy Goryachev <[email protected]> wrote:
>> That's not what I meant. The test, for whatever reason, is testing a >> perfectly valid scenario - mouse press followed by a release. The real >> question is why did you have to change it? >> >> The test works fine with and without your changes on macOS. There might be >> something in the fx code that handles platform differences between mac and >> windows, so if the test failed on windows, it means this PR broke something. > > yep, the original test is broken on windows with this change. > > we shouldn't be changing test by replacing a legal sequence of events to an > illegal one just to silence it. I must be blind - I thought that the test previously pressed and pressed again. And was wondering what it tried to achieve - just realized that it was press -> release. well, that is probably what happens if you name your test `test_rt_32869` and let me guess what it does 🙃 ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1935#discussion_r3284851124
