On Mon, 1 Jun 2026 19:28:43 GMT, Marius Hanl <[email protected]> wrote:
>> modules/javafx.fxml/src/main/java/javafx/fxml/FXMLLoader.java line 127:
>>
>>> 125: // a default property that is a list
>>> 126: boolean collection;
>>> 127: if (value instanceof List<?> || value instanceof Set<?>) {
>>
>> shouldn't this be `instanceof Collection` then?
>> (and I don't think generics are needed for `instanceof` since it's runtime
>> check and type is erased)
>
> Without `<?>`, we will usually get a warning. I think its okay to keep. But
> I'm also wondering if we should check for the generic `Collection` class
just curious - what kind of warning? My Eclipse shows no warnings, but then
again, I have some disabled.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2167#discussion_r3336715535
