On Mon, 1 Jun 2026 18:50:32 GMT, Andy Goryachev <[email protected]> wrote:
>> Petr Štechmüller has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Make sure instantiation works also when ProxyBuilder is not used > > modules/javafx.fxml/src/test/java/test/javafx/fxml/RT_8203870Test.java line > 25: > >> 23: assertEquals(2, widget.getObservableMap().size()); >> 24: >> 25: // assertEquals(3, widget.getNames().length); > > is there a reason to keep commented out lines? Yes, there is a reason. During testing, I find out that array creation in combination of @NamedArg also does not work. When I was investigating why and trying to find a solution for it, it would require a bit more digging and I'm not sure whether to do it as part of this PR or a new one (I would preffer new one, because I expect bigger changes). ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2167#discussion_r3338956642
