On Mon, 8 Jun 2026 19:20:51 GMT, Andy Goryachev <[email protected]> wrote:
>> Ziad El Midaoui has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Minor change to parameters
>
> modules/javafx.controls/src/test/java/test/com/sun/javafx/scene/control/skin/modena/TextInputControlModenaTest.java
> line 179:
>
>> 177: }
>> 178:
>> 179: private static Text getPromptNode(TextInputControl control) {
>
> I wonder if we should move it to the `TextInputSkinShim` instead, something
> like this:
>
> public static Text getPromptNode(TextInputControl c) {
> var skin = c.getSkin();
> if(skin instanceof TextFieldSkin skin) {
> return skin.getPromptNode();
> } else if(skin instanceof TextAreaSkin skin) {
> return skin.getPromptNode();
> }
> ...
>
>
> it will impact other tests, but probably cleaner long term.
Yes it is cleaner, currently there is a `getPromptNode()` method for
`TextField` and `TextArea` only in `TextInputSkinShim`, but adding this new
method would require us to make a change to many tests, maybe we can do this in
another ticket and refactor it? what do you think ?
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2184#discussion_r3380274341
