On Wed, 10 Jun 2026 02:46:19 GMT, Ziad El Midaoui <[email protected]> wrote:
>> This fixes a `TextInputControl` styling issue where prompt text is hidden >> when an empty text input control receives focus. >> The fix removes the focused-state override `-fx-prompt-text-fill: >> transparent;` so focused empty text inputs continue to use the normal Modena >> prompt text fill. >> The prompt text now stay visible when a text input control is focused. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Ziad El Midaoui has updated the pull request incrementally with one > additional commit since the last revision: > > Added new getPromptNode() method to TextInputSkinShim Copyright header was not adjusted but since @arapte runs a script at one point -> probably optional. Fix is simple, tests looks good but I wonder about the user agent stylesheet. modules/javafx.controls/src/test/java/test/com/sun/javafx/scene/control/skin/modena/TextInputControlModenaTest.java line 152: > 150: > 151: try { > 152: > Application.setUserAgentStylesheet(Application.STYLESHEET_MODENA); Why is that done here? Never saw it before so I just removed it locally and the test still pass and fails without the fix. ------------- Changes requested by mhanl (Committer). PR Review: https://git.openjdk.org/jfx/pull/2184#pullrequestreview-4544213198 PR Review Comment: https://git.openjdk.org/jfx/pull/2184#discussion_r3452349547
