On Sun, 14 Jun 2026 15:01:51 GMT, Michael Strauß <[email protected]> wrote:
>> Thiago Milczarek Sayao has updated the pull request with a new target base >> due to a merge or a rebase. The pull request now contains 39 commits: >> >> - Remove configurable delays >> - Fix test >> - Xorg fixes >> - Revert "Rewrite WrongStageFocusWithApplicationModalityTest because it >> fails intermittently" >> >> This reverts commit c6b9dd745e5d762adb89a3b596e53b0d8a790d7f. >> - Rewrite WrongStageFocusWithApplicationModalityTest because it fails >> intermittently >> - Use existing verbose flag for GTK >> - Fix window size update >> - StageOwnershipTest: Update Y_DELTA >> - Copyright year >> - Merge branch 'master' into 8354943_v2 >> - ... and 29 more: https://git.openjdk.org/jfx/compare/b690b3c4...68d684f9 > > modules/javafx.graphics/src/main/native-glass/gtk/glass_general.h line 49: > >> 47: #define ALPHA_CHANNEL_ERROR_MSG \ >> 48: "Can't create transparent stage, because your screen doesn't support >> alpha channel. " \ >> 49: "You need to enable XComposite extension.\n" > > If you are touching this code, maybe you should consider improving the > language. In particular, readers shouldn't be colloquially addressed with > "you". Maybe something like: > "Cannot create a transparent stage because the screen does not support an > alpha channel without enabling the XComposite extension." I updated the error message (though it's very unlikely to ever be shown). ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2139#discussion_r3410037586
