On Sun, 14 Jun 2026 15:22:18 GMT, Michael Strauß <[email protected]> wrote:
>> Thiago Milczarek Sayao has updated the pull request with a new target base >> due to a merge or a rebase. The pull request now contains 39 commits: >> >> - Remove configurable delays >> - Fix test >> - Xorg fixes >> - Revert "Rewrite WrongStageFocusWithApplicationModalityTest because it >> fails intermittently" >> >> This reverts commit c6b9dd745e5d762adb89a3b596e53b0d8a790d7f. >> - Rewrite WrongStageFocusWithApplicationModalityTest because it fails >> intermittently >> - Use existing verbose flag for GTK >> - Fix window size update >> - StageOwnershipTest: Update Y_DELTA >> - Copyright year >> - Merge branch 'master' into 8354943_v2 >> - ... and 29 more: https://git.openjdk.org/jfx/compare/b690b3c4...68d684f9 > > modules/javafx.graphics/src/main/native-glass/gtk/glass_window.cpp line 1680: > >> 1678: } >> 1679: >> 1680: if (mapped) { > > This looks a bit suspicious: `move_resize()` uses `mapped` to decide whether > to call `gtk_window_resize()` or `gtk_window_set_default_size()`. The old > code used `gtk_widget_get_realized()` and resized any realized window. Since > the `mapped` field is always false for a `POPUP` window, the new code might > not resize an already-realized popup. Popups go through the same process of setting `mapped` to `true`. However, I'll do some testing to verify popup move and resize behavior. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2139#discussion_r3410561186
