On Thu, 4 Jun 2026 22:38:39 GMT, Michael Strauß <[email protected]> wrote:
>> Several JavaFX controls use animations to convey state changes, some of >> which are controllable by developers (for example: `TitledPane.animated` or >> `Chart.animated`). However, none of those controls respect the >> `reducedMotion` preference that was introduced with >> [JDK-8341514](https://bugs.openjdk.org/browse/JDK-8341514). >> >> This enhancement changes the behavior of the following control skins to take >> the `Scene.Preferences.reducedMotion` preference into account when >> determining whether to animate a state change: >> >> * `TableRowSkinBase` >> * `TitledPaneSkin` >> * `TabPaneSkin` >> * `PaginationSkin` >> * Charts >> >> For controls whose animation can be toggled by developers, it is useful to >> think of the `animated` property as the application choice, while >> `reducedMotion` is the user choice. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Michael Strauß has updated the pull request incrementally with one additional > commit since the last revision: > > review comments Tested and works fine. The behavior matches what modern browsers do. Skin implementations look fine and as discussed, no issues regarding potential memory leaks (I did some checks with `JMemoryBuddy` as well - all good). ------------- Marked as reviewed by mhanl (Committer). PR Review: https://git.openjdk.org/jfx/pull/2177#pullrequestreview-4497031804
