On Sun, 14 Jun 2026 20:01:33 GMT, Michael Strauß <[email protected]> wrote:
> I think you're arguing that it's safer Yeah, that's what I was thinking. I just wanted to make sure we weren't overlooking anything regarding memory leaks (And the fact that setting fields to `null` seems to be a recurring pattern in JavaFX Skins). But I checked it using `JMemoryBuddy` and manually, and everything looks fine! Sorry for the confusion, and thanks for the explanation. > I'm not sure whether we're on the same page here. There's no possibility to > reuse a SkinBase-based skin other than to implement it incorrectly Right. I was referring to skins derived from `Skin` directly, since they could be programmed so that `dispose` removes the inner working and `install` reinstalls them. The class that comes closest to this and might work - assuming the logic resides in `install` instead - is JavaFX's `InputFieldSkin`. But that has nothing to do with this PR. I was just wondering if it might make sense at some point to allow the reuse of all JavaFX skins, since we already have the necessary architecture in place. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2177#discussion_r3413172251
