On Mon, 22 Jun 2026 14:22:00 GMT, Andy Goryachev <[email protected]> wrote:

>> Ok I think I know what may was going on. 
>> 
>> There is another test that will not correctly reset the application user 
>> agent stylesheet.
>> I created https://bugs.openjdk.org/browse/JDK-8387020 with more details and 
>> will create a PR ~soon~. done.
>> 
>> In my opinion, we should remove 
>> `Application.setUserAgentStylesheet(Application.STYLESHEET_MODENA);` here, 
>> because for one, it's the default anyway, and if another test incorrectly 
>> sets the user-agent stylesheet, this test shouldn't hide that - it should 
>> fail.
>
> I think this is good as is - the bug calls for Modena.css specifically, so 
> the test ensures the right stylesheet.
> And thanks for filing JDK-8387020 - it is indeed a weird choice of data url.

Okay but then we may should do that in the `setup` and reset in `cleanup` 
perhaps? Because the other test `testHighlightTextInput` failed because of 
JDK-8387020, so it is also affected when modena is not set.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/2184#discussion_r3453066624

Reply via email to