On Tue, 23 Jun 2026 11:54:18 GMT, Florian Kirmaier <[email protected]> wrote:
>> This PR fixes the computeSize methods not considering the gap in some cases. >> >> It also fixes a missed spot, in the previous PR for JDK-8092379. >> >> Each fix is covered by simple tests which fail before and work after the >> change. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Florian Kirmaier has updated the pull request incrementally with one > additional commit since the last revision: > > JDK-8386590 > Small improvements based on code-review Thank you for adding a reproducer! Unfortunately, I still not sure what I am looking at. Could you tell what is expected vs. what is observed? Also, the reproducer seems to contain questionable code: there are multiple overlapping labels <img width="273" height="44" alt="Screenshot 2026-06-25 at 08 17 32" src="https://github.com/user-attachments/assets/59d1b68c-768f-46e3-9b3b-85582769065e"; /> later constraints override the earlier ones: result.add(innerContent, 2, 1); // col=2, row=1 ... then GridPane.setConstraints(innerContent, 0, 0, 2, 1); // col=0, row=0 ------------- PR Comment: https://git.openjdk.org/jfx/pull/2187#issuecomment-4800979144
