On Tue, 23 Jun 2026 11:54:18 GMT, Florian Kirmaier <[email protected]> wrote:
>> This PR fixes the computeSize methods not considering the gap in some cases. >> >> It also fixes a missed spot, in the previous PR for JDK-8092379. >> >> Each fix is covered by simple tests which fail before and work after the >> change. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Florian Kirmaier has updated the pull request incrementally with one > additional commit since the last revision: > > JDK-8386590 > Small improvements based on code-review I've slightly adapted the Test-Application. The "Overlapping elements" are required to reproduce the bug. With 25 or before JDK-8092379 they are not required - but afterwards they are needed to reproduce the bug. The overlapping-element no longer has text but a colored background instead. This makes the app look less buggy. Removed the overwritten position for the main-element - which didn't have much effect but was a codesmell. But still basically the same app. When the app is resized so the TextFlow can render with 1 line without much space left, then the rendering bug is visible. With JFX26: <img width="279" height="325" alt="Screenshot 2026-06-30 at 12 04 29" src="https://github.com/user-attachments/assets/93fca6a1-ddfc-405b-920b-a70fc85a27eb"; /> With build from PR: <img width="286" height="377" alt="Screenshot 2026-06-30 at 12 05 12" src="https://github.com/user-attachments/assets/f626e1c0-d618-4b89-aa5a-ae60541b1cbb"; /> ------------- PR Comment: https://git.openjdk.org/jfx/pull/2187#issuecomment-4842196189
