On Thu, 9 Jul 2026 18:06:48 GMT, Andy Goryachev <[email protected]> wrote:

>> John Hendrikx has updated the pull request incrementally with one additional 
>> commit since the last revision:
>> 
>>   Fix flakey check on (asynchronous) stderr output
>
> modules/javafx.base/src/main/java/com/sun/javafx/binding/ArrayManager.java 
> line 85:
> 
>> 83: 
>> 84:     /**
>> 85:      * Gets the occupied slots of the array under management.
> 
> it's an internal class, but "occupied slots" is confusing - the number of, or 
> some kind of bitmap telling which slots are occupied and which are not?

This refers to the number of elements that are currently valid (or in use) in 
the array. Only the elements [0, occupiedSlots) can be used. It is similar to 
the size/capacity split for `ArrayList`, except you can access the array 
directly (if you dare to cast it) and I'd like to avoid confusing with 
array.length (which would not be the number of occupied slots, but would be the 
capacity).

I will clarify the doc.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/1081#discussion_r3558825558

Reply via email to