On Thu, 9 Jul 2026 18:28:57 GMT, Andy Goryachev <[email protected]> wrote:
>> John Hendrikx has updated the pull request incrementally with one additional >> commit since the last revision: >> >> Fix flakey check on (asynchronous) stderr output > > modules/javafx.base/src/main/java/com/sun/javafx/binding/ArrayManager.java > line 260: > >> 258: * that satisfy the given predicate. If the predicate throws errors >> or >> 259: * exceptions, these are relayed to the caller, and the state of >> the array >> 260: * will be undefined. > > interesting. should it remain in some safe configuration instead? It's only purpose really is to remove `null`s and I made it a bit more generic in case other JavaFX code later wants to use managed arrays via `ArrayManager`. Since I want to make sure that people are not making assumptions, I documented that using it incorrectly is unspecified (so no assumptions of some fancy transactional logic that would cost performance). I could have just added a `removeNulls` function, but since I think this code could be useful for other arrays that JavaFX may want to manage now or in the future, a slightly more generic (but still simple) implementation seemed good enough for code that is managing arrays manually (you already need to know what you're doing if you're optimizing that deep). ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/1081#discussion_r3558900379
