On Sun, 12 Jul 2026 17:29:06 GMT, Petr Štechmüller <[email protected]> wrote:
>> modules/javafx.fxml/src/test/java/test/com/sun/javafx/fxml/builder/ProxyBuilderTest.java
>> line 117:
>>
>>> 115: pb.put("b", 456);
>>> 116: ImmutableClass result = (ImmutableClass) pb.build();
>>> 117: assertEquals(123, result.a, 0.00001);
>>
>> I just saw that below, you were using `1e-5f`, lets use it here and below as
>> well
>> Suggestion:
>>
>> assertEquals(123, result.a, 1e-5f);
>
> I have changed this because you asked for change in some other comment. So
> should I put `1e-5f` there?
Yes I said it in another comment. But I reviewed it again and saw that you were
using `1e-5f` in the other tests, so I think we should use it here as well to
be consistent.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2167#discussion_r3566775764
