On Sat, 11 Jul 2026 17:04:06 GMT, Marius Hanl <[email protected]> wrote:
>> By "all other types" you mean `Set` and `List`? They are covered by >> `Collection` check above. > > What I mean is, we have the following conditions: > - `Collection.class.isAssignableFrom(retType) && argType.length == 0` > - `Map.class.isAssignableFrom(retType) && argType.length == 0 && > !strsMap.containsKey(propName)` > - `ObservableArray.class.isAssignableFrom(retType) && argType.length == 0` > > And I was wondering why only for the `Map` if condition we have the > additional `!strsMap.containsKey(propName)` check Oh I see it now. It is not necessary. I think it might be just a relic of me testing whether it will perform a bit better with additional check. So no special need for this. Can be removed. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2167#discussion_r3564673871
