On Thu, 23 Jul 2026 19:26:58 GMT, Andy Goryachev <[email protected]> wrote:
>> +1 for removing it.
>
> you mean removing the spec "_This method is called before any styles are
> looked up for the given property._" ?
Yes, I don't think that should have been in the spec in the first place, as it
reveals basically the inner workings of the CSS system. Also, we're still
respecting the return value of `isSettable` -- we're not calling `applyStyle`
(which would indeed result in the "expansion of the property" the documentation
alludes to). We're merely looking up the styles, something the documentation
specifically says it won't do -- but why guarantee that in the first place?
So I suggest rewriting the docs to:
* Check to see if the corresponding property on the given Node is
* settable. This method is called before any call to {@code applyStyle} is
* made. It is abstract so that the code can check if the property
* is settable without expanding the property. Generally, the property is
* settable if it is not null or is not bound.
Changing the sentence "This method is called before any styles are looked up
for the given property." to "This method is called before any call to {@code
applyStyle} is made." -- in both cases this ensures the property is not
expanded unnecessarily, but gives the CSS system the freedom to still evaluate
the stylesheet so it can create a shared cache entry that is complete.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2218#discussion_r3641895598
