On Mon, 17 Aug 2026 18:06:39 GMT, Andy Goryachev <[email protected]> wrote:

>> The parameters here are _input parameters_. As Alex says, there aren't any 
>> (unlike the `BOUNDS_FOR_RANGE` attribute where there are).
>
> I don't understand - it does not matter what kind of parameters they are, 
> they need to be documented.  How am I supposed to provide VISIBLE_ITEM_RANGE 
> in RichTextArea?
> 
> `ListViewSkin` L386 returns the `int[]` with `{ firstIndex, count }` which 
> needs to be documented.  
> 
> Specifically,
> - `int[] { firstIndex, count }` must be documented
> - `int[] { 0, 0 }` case must be documented
> - the fact that it is a non-null int[2] should probably be mentioned

I was referring to the first inline comment that you made above on this line, 
which is `* <li>Parameters: </li>`:

> Parameters: should describe the structure (see BOUNDS_FOR_RANGE for example)

There are no parameters.

> ListViewSkin L386 returns the int[] with { firstIndex, count } which needs to 
> be documented.

So you are saying that the _return value_ (not parameters) needs to better 
documented. Quite possibly.

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/2217#discussion_r3797845302

Reply via email to