On Sat, 5 Sep 2026 13:20:04 GMT, Marius Hanl <[email protected]> wrote:
>> Michael Strauß has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 12 commits: >> >> - add ctor overloads to SimpleStyleable* properties >> - Merge branch 'master' into feature/property-metadata >> - revert >> - remove test >> - Update javadocs >> - Merge branch 'master' into feature/property-metadata >> >> # Conflicts: >> # modules/javafx.graphics/src/main/java/javafx/scene/layout/HeaderBar.java >> - Merge branch 'master' into feature/property-metadata >> >> # Conflicts: >> # modules/javafx.graphics/src/test/addExports >> - Merge branch 'master' into feature/property-metadata >> - review changes >> - ReadOnlyProperty.getDeclaringClass() tests >> - ... and 2 more: https://git.openjdk.org/jfx/compare/6670f897...78a38fa8 > > modules/javafx.base/src/main/java/javafx/beans/property/ReadOnlyProperty.java > line 102: > >> 100: && >> ReadOnlyProperty.class.isAssignableFrom(method.getReturnType())) { >> 101: return beanClass; >> 102: } > > I was still wondering if it might make sense to log a `warning` or just an > `info` that this is really is a fallback implementation and developers should > rather override this / set the declaring `Class` instead. > > All opinions welcome. On a similar note, when the reflection failed, it will always be retried, right? Since we return `null` and so the subclass will call this again the next time ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2015#discussion_r3940781421
