On Sat, 5 Sep 2026 13:39:26 GMT, Marius Hanl <[email protected]> wrote:
>> Michael Strauß has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 12 commits: >> >> - add ctor overloads to SimpleStyleable* properties >> - Merge branch 'master' into feature/property-metadata >> - revert >> - remove test >> - Update javadocs >> - Merge branch 'master' into feature/property-metadata >> >> # Conflicts: >> # modules/javafx.graphics/src/main/java/javafx/scene/layout/HeaderBar.java >> - Merge branch 'master' into feature/property-metadata >> >> # Conflicts: >> # modules/javafx.graphics/src/test/addExports >> - Merge branch 'master' into feature/property-metadata >> - review changes >> - ReadOnlyProperty.getDeclaringClass() tests >> - ... and 2 more: https://git.openjdk.org/jfx/compare/6670f897...78a38fa8 > > modules/javafx.base/src/main/java/javafx/beans/property/SimpleStringProperty.java > line 67: > >> 65: */ >> 66: @Override >> 67: public Class<?> getDeclaringClass() { > > Minor question, but since we now add the new API, we should probably think > about it. > Should we rather make all `getDeclaringClass()` methods final for all > `Simple*Property` classes? Good question. Developers can override `getBean()` and `getName()` even for the Simple* properties (and we probably can't change that). I think we should then also allow that for `getDeclaringClass()` to be consistent. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2015#discussion_r3940935555
