On Tue, 8 Sep 2026 20:17:17 GMT, Andy Goryachev <[email protected]> wrote:
>> Marius Hanl has updated the pull request incrementally with one additional >> commit since the last revision: >> >> numpad logic and VK_SPACE and tests for them > > modules/javafx.graphics/src/main/java/com/sun/glass/ui/headless/HeadlessApplication.java > line 262: > >> 260: case '.' -> KeyEvent.VK_PERIOD; >> 261: case '/' -> KeyEvent.VK_SLASH; >> 262: default -> KeyEvent.VK_UNDEFINED; > > what about " " -> `VK_SPACE`? added > modules/javafx.graphics/src/main/java/com/sun/glass/ui/headless/HeadlessApplication.java > line 281: > >> 279: case '^' -> '6'; >> 280: case '&' -> '7'; >> 281: case '*' -> '8'; > > looks like it will break if numpad is used. > example: (Numpad-*) is converted to 8 instead of `KeyCode.MULTIPLY`, right? added as well ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2297#discussion_r3963515015 PR Review Comment: https://git.openjdk.org/jfx/pull/2297#discussion_r3963517027
