On Tue, 8 Sep 2026 20:30:11 GMT, Andy Goryachev <[email protected]> wrote:
>> Marius Hanl has updated the pull request incrementally with one additional >> commit since the last revision: >> >> numpad logic and VK_SPACE and tests for them > > tests/system/src/test/java/test/com/sun/glass/ui/headless/HeadlessApplicationKeyCombinationTest.java > line 76: > >> 74: assertTrue(match); >> 75: } >> 76: > > extra newline Using a space as a KeyCharacterCombination would be very unusual and probably lead to sadness. It's not incorrect to test for this but you are testing for a KeyCharacterCombination which is probably not used in the wild. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2297#discussion_r3970671416
