On Wed, 9 Sep 2026 13:05:08 GMT, Ajit Ghaisas <[email protected]> wrote:
>> This is a minor test cleanup fix. >> Note : All tests in `ControlTooltipTest` were disabled/ignored since >> beginning. >> >> Fix : >> The test cases used to make an incorrect assumption that adding a `Tooltip` >> to a `Control` adds it to `Control`'s children list. The old test cases are >> discarded and new unit tests are added to test setting a `Tooltip` on a >> `Control`. >> >> --------- >> - [x] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Ajit Ghaisas has updated the pull request incrementally with one additional > commit since the last revision: > > Rename variables Marked as reviewed by mhanl (Reviewer). modules/javafx.controls/src/test/java/test/javafx/scene/control/ControlTooltipTest.java line 72: > 70: // Test Tooltip install > 71: Tooltip.install(control, tooltip); > 72: Node node = (Node) control; minor: cast here can be removed modules/javafx.controls/src/test/java/test/javafx/scene/control/ControlTooltipTest.java line 84: > 82: @Test public void testTooltipInstallTwiceOnControl() { > 83: Tooltip.install(control, tooltip); > 84: Node node = (Node) control; minor: cast here can be removed ------------- PR Review: https://git.openjdk.org/jfx/pull/2304#pullrequestreview-5154802703 PR Review Comment: https://git.openjdk.org/jfx/pull/2304#discussion_r3968823924 PR Review Comment: https://git.openjdk.org/jfx/pull/2304#discussion_r3968824721
