On Wed, 9 Sep 2026 17:35:21 GMT, Marius Hanl <[email protected]> wrote:
>> modules/javafx.controls/src/test/java/test/javafx/scene/control/ControlTooltipTest.java
>> line 47:
>>
>>> 45: }
>>> 46:
>>> 47: @Test public void controlHasNoTooltipByDefault() {
>>
>> this is minor, but maybe we should move `@Test` annotation on its own line,
>> especially since the whole thing shows up as modified in the diff
>>
>> (otherwise, lgtm)
>
> I had the same thought actually, but did not comment as it was the same
> before.
> Would be fine for me as well -- while here we could also drop `public` as it
> is not needed as well (since JUnit 5). Also very minor obviously.
maybe keep `public` for human pattern recognition. there is no reason to drop
it, I think.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2304#discussion_r3971323117
