On Thu, 10 Sep 2026 00:37:17 GMT, Michael Strauß <[email protected]> wrote:

>> When a binary stylesheet contains CSS transitions, deserialization fails 
>> with errors similar to:
>> 
>> SEVERE: could not deserialize 
>> com.sun.javafx.css.TransitionDefinitionConverter
>> 
>> 
>> The reason is that the `StyleConverter.getInstance(String)` factory used to 
>> deserialize converters doesn't include the converters that were added to 
>> support CSS transitions.
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Michael Strauß has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   serialize number types

modules/javafx.graphics/src/test/java/test/javafx/css/ParsedValueTest.java line 
507:

> 505: 
> 506:     @Test
> 507:     public void testWriteAndReadBinaryNumbers() {

why do we need to serialize all these types, shouldn't we just support 
`double`s?
CSS makes no distinction between an `int` or a `byte` or a `short`, does it?

-------------

PR Review Comment: https://git.openjdk.org/jfx/pull/2303#discussion_r3980745996

Reply via email to