On Thu, 10 Sep 2026 15:38:57 GMT, Michael Strauß <[email protected]> wrote:
>> modules/javafx.graphics/src/test/java/test/javafx/css/ParsedValueTest.java
>> line 507:
>>
>>> 505:
>>> 506: @Test
>>> 507: public void testWriteAndReadBinaryNumbers() {
>>
>> why do we need to serialize all these types, shouldn't we just support
>> `double`s?
>> CSS makes no distinction between an `int` or a `byte` or a `short`, does it?
>
> CSS has at least integers in addition to doubles. My thinking is that if
> we're changing the format spec, why not support all primitive numbers?
that's not what I meant. like javascript, CSS effectively uses doubles,
meaning it parses the number and sets a double or an int property, even
permitting a fractional value for an integer property:
`-fx-tab-size:1.1;` is perfectly valid spec (I think it simply casts to `int`
instead of rounding)
so, all we need is to support doubles only.
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2303#discussion_r3981256098
