On Tue, 22 Sep 2026 18:57:22 GMT, Ziad El Midaoui <[email protected]> 
wrote:

>> Improved the manual test instructions and pass/fail criteria for the 
>> following tests :
>> 
>> - NotResizableWindowTest
>> - DndBasic
>> - DndTestDragViewRawImage
>> - PrintDialogModalityTest
>> - PrintOrientTest
>> - StartIconified
>> - DragDropFromSwingComponentInSwingNodeTest
>> - DragDropOntoJavaFXControlInJFXPanelTest
>> - EmojiTest
>> - EventListenerLeak
>> - InputTypeAcceptAttributeTest
>> - GifImageTestApp
>> 
>> ---------
>> - [x] I confirm that I make this contribution in accordance with the 
>> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai).
>
> Ziad El Midaoui has updated the pull request incrementally with one 
> additional commit since the last revision:
> 
>   Clarify instructions for StartIconified on macOS

Approved with one minor wording suggestion. I'll reapprove if you change (but 
OK as-is).

tests/manual/dnd/DndTestDragViewRawImage.java line 64:

> 62:                 The colors of the drag image displayed with the cursor 
> (drag view)
> 63:                 must be similar to those of the source image, but may not 
> be identical
> 64:                 due to transparency. You may ignore this size difference 
> of the drag image in some cases.

Suggestion:

                due to transparency. You may ignore any difference in the size 
of the drag image.

-------------

Marked as reviewed by kcr (Lead).

PR Review: https://git.openjdk.org/jfx/pull/2315#pullrequestreview-5283078014
PR Review Comment: https://git.openjdk.org/jfx/pull/2315#discussion_r4075895472

Reply via email to