On Tue, 22 Sep 2026 20:00:26 GMT, Kevin Rushforth <[email protected]> wrote:
>> Ziad El Midaoui has updated the pull request incrementally with one >> additional commit since the last revision: >> >> Clarify instructions for StartIconified on macOS > > tests/manual/dnd/DndTestDragViewRawImage.java line 64: > >> 62: The colors of the drag image displayed with the cursor >> (drag view) >> 63: must be similar to those of the source image, but may >> not be identical >> 64: due to transparency. You may ignore this size difference >> of the drag image in some cases. > > Suggestion: > > due to transparency. You may ignore any difference in the > size of the drag image. pass/fail criteria should be crisp and unambiguous, maybe "The test passes if the drag image displayed with the cursor (drag view) is visually similar to the source image" or "The test fails if the drag image displayed with the cursor looks nothing like the source image" ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2315#discussion_r4075965423
