On Fri, 18 Sep 2026 18:02:43 GMT, Andy Goryachev <[email protected]> wrote:
>> Marius Hanl has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 10 commits: >> >> - Merge branch 'master' of https://github.com/openjdk/jfx into >> 8388277-REDO]-Looked-up-color-fails-for--fx-background-color-in-JavaFX-CSS-file >> - fix >> - test >> - idea how to fix that issue >> - failing test >> - Fix another broken case >> - change the way we process a stale CssStyleHelper >> - Merge branch 'master' of https://github.com/openjdk/jfx into >> 8388277-REDO]-Looked-up-color-fails-for--fx-background-color-in-JavaFX-CSS-file >> - Merge branch 'master' of https://github.com/openjdk/jfx into >> 8388277-REDO]-Looked-up-color-fails-for--fx-background-color-in-JavaFX-CSS-file >> >> # Conflicts: >> # >> modules/javafx.graphics/src/test/java/test/javafx/scene/CssStyleHelperTest.java >> - 8388277: [REDO] Looked-up color fails for -fx-background-color in JavaFX >> CSS file > > modules/javafx.graphics/src/main/java/javafx/scene/CssStyleHelper.java line > 157: > >> 155: >> 156: final StyleMap styleMap = >> 157: StyleManager.getInstance().findMatchingStyles(node, >> node.getSubScene(), triggerStates); > > I think we still have a problem: `findMatchingStyles` can re-enter CSS and > see the ancestors as stale, so it will try to re-build them, possibly in a > loop. > > a solution might be to introduce `RESOLVING` state which prevents that > (similar to `Parent.performingLayout` flag) How? `findMatchingStyles`only reads the state of the `Node`, that is all styles, pseudo classes, selectors,... ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2225#discussion_r4174063113
