On Fri, 18 Sep 2026 18:29:49 GMT, Andy Goryachev <[email protected]> wrote:
>> Marius Hanl has updated the pull request with a new target base due to a >> merge or a rebase. The pull request now contains 10 commits: >> >> - Merge branch 'master' of https://github.com/openjdk/jfx into >> 8388277-REDO]-Looked-up-color-fails-for--fx-background-color-in-JavaFX-CSS-file >> - fix >> - test >> - idea how to fix that issue >> - failing test >> - Fix another broken case >> - change the way we process a stale CssStyleHelper >> - Merge branch 'master' of https://github.com/openjdk/jfx into >> 8388277-REDO]-Looked-up-color-fails-for--fx-background-color-in-JavaFX-CSS-file >> - Merge branch 'master' of https://github.com/openjdk/jfx into >> 8388277-REDO]-Looked-up-color-fails-for--fx-background-color-in-JavaFX-CSS-file >> >> # Conflicts: >> # >> modules/javafx.graphics/src/test/java/test/javafx/scene/CssStyleHelperTest.java >> - 8388277: [REDO] Looked-up color fails for -fx-background-color in JavaFX >> CSS file > > modules/javafx.graphics/src/main/java/javafx/scene/CssStyleHelper.java line > 111: > >> 109: // Listeners running while the old helper reset >> properties may have changed the hierarchy. >> 110: // The remaining stale ancestors must not be rebuilt >> for an outdated path, so start over. >> 111: if (propertiesReset && !isPathValid(path)) { > > a listener can make the newly installed helper stale again (for example, by > changing the ancestor style). we probably need to restart when the updated > node becomes stale again (in addition to checking the path). this should happen now. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2225#discussion_r4174040434
