On Tue, 13 Oct 2026 13:02:00 GMT, Robert Lichtenberger <[email protected]> wrote:
>> As analysed in the bug, the previousWord() method does not work correctly if >> at the word boundary a character is found that is neither letter nor digit. >> This fix changes the method so that only ranges of whitespace will be >> skipped, resulting in correct word selection behaviour. >> A test case has been added to TextAreaTest. >> gradlew :controls:test --tests test.javafx.scene.control.Text*Test has been >> executed to ensure no regressions happen in other text related classes. No >> errors were reported. >> >> >> --------- >> - [X] I confirm that I make this contribution in accordance with the >> [OpenJDK Interim AI Policy](https://openjdk.org/legal/ai). > > Robert Lichtenberger has updated the pull request incrementally with one > additional commit since the last revision: > > 8264588: Split test case for windows / non-windows OS Looks good and works fine on Linux. modules/javafx.controls/src/test/java/test/javafx/scene/control/behavior/TextAreaBehaviorTest.java line 37: > 35: import org.junit.jupiter.api.Disabled; > 36: import org.junit.jupiter.api.Test; > 37: import test.com.sun.javafx.scene.control.infrastructure.MouseEventFirer; Import is now unused modules/javafx.controls/src/test/java/test/javafx/scene/control/behavior/TextAreaBehaviorTest.java line 152: > 150: @Test > 151: @Disabled("JDK-8393470") > 152: public void testDoubleClickSelectsCharacterClassBlocks() { Not a big fan of a big test that tests multiple things (in this case `#`, `...x`, ` `, `,,,`, `\t`) -- I'm more in favor of a parameterized test or separate tests. But this is a nitpick, so fine for me as is. ------------- PR Review: https://git.openjdk.org/jfx/pull/2334#pullrequestreview-5515235680 PR Review Comment: https://git.openjdk.org/jfx/pull/2334#discussion_r4268568832 PR Review Comment: https://git.openjdk.org/jfx/pull/2334#discussion_r4268718200
