On Tue, 13 Oct 2026 20:09:23 GMT, Andy Goryachev <[email protected]> wrote:
>> Florian Kirmaier has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> JDK-8392169
>> GridPane - minor formating changes
>
> modules/javafx.graphics/src/main/java/javafx/scene/layout/GridPane.java line
> 1853:
>
>> 1851: }
>> 1852:
>> 1853: private double adjustRowHeights(final CompositeSize heights,
>> double height, CompositeSize widths) {
>
> don't need `final` here
done
> modules/javafx.graphics/src/main/java/javafx/scene/layout/GridPane.java line
> 2098:
>
>> 2096: }
>> 2097:
>> 2098: private double adjustColumnWidths(final CompositeSize widths,
>> double width, CompositeSize heights) {
>
> final
done
> modules/javafx.graphics/src/main/java/javafx/scene/layout/GridPane.java line
> 2298:
>
>> 2296: boolean isPositive = wasPositive;
>> 2297:
>> 2298: CompositeSize limitSize = shrinking? computeMinWidths(heights)
>> :
>
> maybe add a space before ?
done
-------------
PR Review Comment: https://git.openjdk.org/jfx/pull/2313#discussion_r4283097455
PR Review Comment: https://git.openjdk.org/jfx/pull/2313#discussion_r4283099852
PR Review Comment: https://git.openjdk.org/jfx/pull/2313#discussion_r4283098587
