On Tue, 13 Oct 2026 21:19:12 GMT, Andy Goryachev <[email protected]> wrote:
>> Florian Kirmaier has updated the pull request incrementally with one >> additional commit since the last revision: >> >> JDK-8392169 >> GridPane - preformacne optimization > > modules/javafx.graphics/src/main/java/javafx/scene/layout/GridPane.java line > 1888: > >> 1886: double remaining = >> growToMultiSpanPreferredHeights(heights, heightAvailable); >> 1887: remaining = growOrShrinkRowHeights(heights, >> Priority.ALWAYS, remaining, widths); >> 1888: remaining = growOrShrinkRowHeights(heights, >> Priority.SOMETIMES, remaining, widths); > > might be pre-existing: computes twice if the layout height is below minimum It's no optimized and computed only once. ------------- PR Review Comment: https://git.openjdk.org/jfx/pull/2313#discussion_r4283313928
